search

manatools / dnfdaemon

DBus daemon for doing package action with the dnf package manager
GNU General Public License v2.0
12 stars 16 forks source link

Choice weak dependencies #45

Open papoteur-mga opened 3 years ago

papoteur-mga commented 3 years ago

Provides the list of package of a transaction with distinction in to install packages: normal dependencies and weak dependencies

Thus in dnfdragora, the weak dependencies can be displayed separately (see issue #185). An entry 'install_weak' is added in the package dictionnary.

I don't understand why the pull request is not only about the last commit. Surely not clean.

timlau commented 3 years ago

@papoteur-mga can you please rebase this PR on top of master, so it only contains the weak dependencies in transaction changes. You should use "import libdnf.transaction", not just "import libdnf" The code is fine, but is is kind of an API break, some of the packages there is returned as being installed, will move to "weak-deps" in the transaction, so changes has to be made in the UI clients, else packages will be installed, but not shown in the UI client transaction result. I have no problems with that and can fix it in yumex-dnf, but dnfdragona properly need changes too.

Conan-Kudo commented 3 years ago

Breaking the API of dnfdaemon is fine, as we haven't declared a stable API yet. The only other consumer right now is dnfdragora, and we're okay to change it as dnfdaemon changes.

anaselli commented 3 years ago

@timlau do you think we can have a talk about dnfdaemon and (dnf) API, dnfdragora and yumex-dnf it would be great if we could work together on these projects, wdyt?

timlau commented 3 years ago

@anaselli fine with me,feel free to mail me. I have started to make a new a dnf-dbus API from scratch https://github.com/timlau/dnf-dbus It is very early in development, but when it matures and get more feature complete it might be an replacement for dnfdaemon with a more modern code base there is easier to maintain and don't break every-time some dnf internals changes.