search

manatools / dnfdaemon

DBus daemon for doing package action with the dnf package manager
GNU General Public License v2.0
12 stars 16 forks source link

Optimize code for dnf-2.0 #6

Closed j-mracek closed 8 years ago

Conan-Kudo commented 8 years ago

@j-mracek Rather than trying to reference private APIs that have no guarantee of availability, how about actually making public APIs that programs like dnfdaemon can use for dnf 2.0?

j-mracek commented 8 years ago

It is correct, this is hot fix that use private method. The code use wide range of dnf calls that is not marked as api, therefore it can be any time broken. But this information is not a secret. Therefore I can only recommend to start deeper refactoring.

timlau commented 8 years ago

Merged, Agree that in the ideal world, every thing need was in the public API, but currently that is not the case, i will use as much public API as i can and try to document the use of private api and limit it as much as possible.

j-mracek commented 8 years ago

If we will know that some function is externally needed, we can mark it as api or try to provide other solution (information can be passed by Bugzilla request).

genodeftest commented 8 years ago

@j-mracek : https://bugzilla.redhat.com/show_bug.cgi?id=1332067 would be nice to see fixed. Haven't looked deeper so there is more to come.

j-mracek commented 8 years ago

Ok, I am working on it.

genodeftest commented 8 years ago

@j-mracek : Thanks for fixing hawkey!

j-mracek commented 8 years ago

@genodeftest Not my work but @ignatenkobrain

ignatenkobrain commented 8 years ago

@genodeftest unfortunately it's still not fixed (I just found workaround), though there is a bug in DNF itself.