search

manatools / dnfdaemon

DBus daemon for doing package action with the dnf package manager
GNU General Public License v2.0
12 stars 16 forks source link

GetGroups does not return the id = icon name for categories #9

Open kkofler opened 7 years ago

kkofler commented 7 years ago

For categories, the GetGroups D-Bus API (implemented in DnfDaemonBase.get_groups in python/dnfdaemon/server/__init__.py) returns the name instead of the id, the id is lost. This is a problem because the id is needed to look up the correct icon in GUIs, both for the category itself, and for groups within the category that do not have their own icons (where, according to https://fedorahosted.org/comps/ , we are supposed to fall back to the category's icon).

kkofler commented 7 years ago

If Yumex-DNF really needs the current behavior of the [0] entry, we need another array entry that reliably contains the ID.

kkofler commented 7 years ago

Any update on this issue? I would really like to get rid of this hardcoded map: https://github.com/anaselli/dnfdragora/blob/master/dnfdragora/compsicons.py#L17 that maps the category names back to the IDs.