search

manatools / dnfdragora

dnfdragora is a dnf frontend based on libyui abstraction
GNU General Public License v3.0
137 stars 41 forks source link

Handle additional DNF 3 progress callback actions #116

Closed AdamWill closed 6 years ago

AdamWill commented 6 years ago

See https://bugzilla.redhat.com/show_bug.cgi?id=1624652 and https://bugzilla.redhat.com/show_bug.cgi?id=1630113 . It seems that DNF 3 sends out additional 'actions' in transaction callbacks, without including them in the callback API or docs. Along with a companion commit to dnfdaemon, this handles them. This commit adds the new actions to const.RPM_ACTIONS so that the on_RPMProgress dbus message handler can deal with them. It also makes on_RPMProgress just log a debug message and continue when a message has an unexpected action, rather than crashing.

Signed-off-by: Adam Williamson awilliam@redhat.com

AdamWill commented 6 years ago

dnfdaemon PR: https://github.com/manatools/dnfdaemon/pull/25

anaselli commented 6 years ago

I can't test it right now, but it seems ok to me. @Conan-Kudo since here it is an addition, should be also back compatible, am i wrong?

AdamWill commented 6 years ago

yeah, the only possible danger here would be if I messed up the try/except syntax somehow, but I don't think I did. :)