search

manatools / dnfdragora

dnfdragora is a dnf frontend based on libyui abstraction
GNU General Public License v3.0
137 stars 41 forks source link

set DefaultButton fix for gtkUI #121

Closed morizzd closed 6 years ago

morizzd commented 6 years ago

Hello everyone, this seems to fix the issue for gtkUI, when pressing Enter in seachfield nothing happens In qtUI setDefaultButton is working for dialog as fine as for button Tested in Fedora 25/28/29, but it really is a problem with libyui-gtk

Morizz

Conan-Kudo commented 6 years ago

@morizzd The change looks good to me, but could you please amend your commit to include the description and reason for the change?

You can do so by using git commit --amend and you'll have the opportunity to edit the message. After that, you can do git push origin -f to push the amended commit to this branch.

anaselli commented 6 years ago

I can't see regression on Qt and either ncurses, but this commit just behave the same as ncurses e.g. Search pushbutton is the default button, but without having the focus on search text field (cursor flashing) is almost useless as issue into #119

morizzd commented 6 years ago

Yes you are right, just getting defaultButton to work without focusing search-field isn't that great. I moved setKeyboardFocus at the end of init function and this is working for qt, gtk and ncurses so far i tested. Could you check that, would be nice if it's working now.

anaselli commented 6 years ago

Well for ncurses is still does not work as using gtk or qt, but i suppose people using ncurses have a good workaround by writing on the text field now focused and then pressing search button by using tab first. LGTM

anaselli commented 6 years ago

this commit fixes #119