search

manatools / dnfdragora

dnfdragora is a dnf frontend based on libyui abstraction
GNU General Public License v3.0
136 stars 41 forks source link

Feature Request: Clicking on Update Notification should open main GUI #211

Open sohang3112 opened 1 year ago

sohang3112 commented 1 year ago

When the update notification appears, then clicking it should open the main GUI so that the packages can be updated.

anaselli commented 1 year ago

we use pystray to implement notification icon. Official documentation is here, any help to improve our work is welcome :)

sohang3112 commented 1 year ago

In this section of the pystray docs, the following is mentioned:

In order to receive notifications about user interaction with the icon, a popup menu can be added with the menu constructor argument.

This must be an instance of pystray.Menu. Please see the reference for more information about the format.

It will be displayed when the right-hand button has been pressed on the icon on Windows, and when the icon has been clicked on other platforms. Menus are not supported on X.

So what I mentioned should be possible to do with pystray.Menu - however I'm not sure if Wayland is supported or not (they have explicitly mentioned that X is NOT supported).

anaselli commented 1 year ago

Updater is here. I used some different DMs on a virtual machine to make my tests. I'm not the original developer for this feature so if you have the time to make some test for this request and a PR eventually, i will glad to make a new dnfdragora release after :) thanks for your help

sohang3112 commented 1 year ago

@anaselli I experimented with the code yesterday - unfortunately pystray doesn't support clickable notifications right now 😔. In this pystray feature request for clickable notifications, the pystray repo owner said clickable notifications might not be possible on some platforms.

Looks like the only way to do this would be to try directly with Gtk / Qt.