search

manatools / dnfdragora

dnfdragora is a dnf frontend based on libyui abstraction
GNU General Public License v3.0
133 stars 41 forks source link

Add info window and fixed segfault #223

Closed norby4ever closed 10 months ago

norby4ever commented 10 months ago

There was no information after finishing packages install. Users asked to add an info window at the end of the transaction, so it was added. There also appeared Segfault error while users were trying to find package with no description. The problem was fixed with the output of an empty line instead of a package description.

anaselli commented 10 months ago

The code is cleaned and easy to read so i can say it's ok for me. Anyway is a dialog at the end of a good transaction really asked by users? In rpmdrake we had once but it's been removed time ago since it was "chatty". Mistakes apart a transaction error should be reported by a dialog already, i didn't think to the need of a good one...

norby4ever commented 10 months ago

The users couldn't understand when the process of packages installing finished and were angry with the tech support team because of not having any information on the time when the installation was finished. Having received a number of such requests, we decided to add this window.

anaselli commented 10 months ago

Pretty odd, I didn't add it as said because it was removed into the tool inspired me :) But I'm not against it I'm happy to have contributors and also if users use dnfdragora ;) Please add you into AUTHORS as contributor, then i'll approve your changes and do a new tag by the end of this week. Thank you

norby4ever commented 10 months ago

Added myself as a contributor, thank you!