manavortex / DailyAutoShare

2 stars 5 forks source link

Grouped quest and GUI: Ashlander relics, Madness and dark anchors #5

Closed vortex9 closed 3 years ago

vortex9 commented 3 years ago

Hi

With "ru" local grouped quests (Ashlander relics, Madness and dark anchors) do not work as planned. In fact with "en" some groups not work too.

  1. Name than generate your code didnt match name from Russian localization It happen because Russian nouns have cases For sample Shadowfen: Nominative: Тенетопь locative: Тенетопи

local fgString = GetString(DAS_GUILD_ANCHORS) .. zoneName from GuildQuests.lua The result of your code is obtained always in the nominative case.

RU-team suggested trick for all languages but it broke GUI or maybe it works but see par.2 below

`local fgString, mgString

for key, value in ipairs({5784, 5785, 5786, 5787, 5788, 5789, 5790, 5791, 5792, 5793, 5794, 5795, 5796, 5797, 5833}) do
    if GetQuestZoneId(value) == id then
        fgString = GetQuestName(value)
        break
    end
end
for key, value in ipairs({5814, 5816, 5818, 5819, 5820, 5822, 5823, 5824, 5825, 5826, 5827, 5828, 5829, 5830, 5831}) do
    if GetQuestZoneId(value) == id then
        mgString = GetQuestName(value)
        break
    end
end`

instead

local zoneName = GetZoneNameByIndex(GetZoneIndex(id)) local fgString = GetString(DAS_GUILD_ANCHORS) .. zoneName local mgString = GetString(DAS_GUILD_MADNESS) .. zoneName

  1. 2nd problem in GUI of submenu groupped quest

bad argument #1 to 'table.insert' (table/struct expected, got nil) stack traceback: [C]: in function 'table.insert' user:/AddOns/DailyAutoShare/DasGui.lua:196: in function 'DAS.SetSubLabels' |caaaaaa<Locals> questTable = [table:1]{1 = "Relics of Ashalmawia"}, status = 1, index = 4, idx = 4, questName = "Relics of Dushariran", label = ud, bingoString = "+dushar", bingoIndex = 24 </Locals>|r user:/AddOns/DailyAutoShare/DasGui.lua:81: in function 'DAS.QuestLabelClicked' |caaaaaa<Locals> control = ud, mouseButton = 1 </Locals>|r Das_Label_1_MouseUp:2: in function '(main chunk)' |caaaaaa<Locals> self = ud, button = 1, upInside = T, ctrl = F, alt = F, shift = F, command = F </Locals>|r

I am good in copying code by template, but not in self-writing it, so I need You need your help

manavortex commented 3 years ago

Hey, I'll look into it, but I'm a bit swamped at the moment. I can't exactly promise when that'll be.

Thank you for fixing this up!

vortex9 commented 3 years ago

I'm not rushing you

Help with any test in game

manavortex commented 3 years ago

Thank you! ♡

On 13 Jul 2021, at 1:33, Vitaliy wrote:

I'm not rushing you

Help with any test in game

-- You are receiving this because you were assigned. Reply to this email directly or view it on GitHub: https://github.com/manavortex/DailyAutoShare/issues/5#issuecomment-878666442

mychaelo commented 3 years ago

@manavortex This issue should be fixed by https://github.com/manavortex/DailyAutoShare/pull/14

manavortex commented 3 years ago

Great to hear, thank you so much ♡