manavortex / DailyAutoShare

2 stars 5 forks source link

Remove timing hacks in favour of dirty flags #56

Closed mychaelo closed 3 years ago

mychaelo commented 3 years ago

This PR gets rid of hacky timers for control refreshing altogether.

Instead, if the window is not shown, the RefreshControl() will just short-cut to setting isDirty and bailing out. The OnShown will call back for the full run of this function whenever it's actually done showing our control.

Fixes situations where the DAS Window would pop in front of the quest journal, inventory etc due to events/hooks calling RefreshControl() while the HUD scene is hidden.