manavortex / FurnitureCatalogue

FurnitureCatalogue
4 stars 9 forks source link

Some German transaltions #132

Closed Lyhtande closed 3 months ago

Lyhtande commented 4 months ago

Hello,

this is Neverlands from ESOUI :)

/locale/de.lua I'm waiting for the permission to directly edit the /locale/de.lua. Here is a link to Gist. It's work in progress, since I could not test every use case.


Here are some further proposals:

/data/AchievementVendors.lua Replacement of locations: File differences report


/data/MiscItemSources.lua Miscellaneous replacements: File differences report


Replacement for the "item craftable info" in Tooltips, when there is a German translation /locale/de.lua - line 57 -58

  SI_FURC_STRING_CRAFTABLE_BY = "Herstellbar von ",
  SI_FURC_STRING_CANNOT_CRAFT = "Ihr könnt das noch nicht herstellen",

FurCTooltip.lua - line 9

 return text:gsub("nicht herstellen", "|cFF0000nicht herstellen"):gsub("Herstellbar", "|c00FF00Herstellbar")

/FurnitureCatalogue_Export/FurCDataExport.lua - line 39

    local knowledge = (known and (FurC.GetCrafterList(itemLink, recipeArray) .. ": "):gsub("Herstellbar von ", ""))

wookiefriseur commented 4 months ago

Thanks for the translations!

You can use a fork + Pull Request to dev to contribute. But if you don't mind I can implement your changes manually, so you don't have to do the fork + PR route.

Whatever is more convenient for you.

Regarding the proposals: Nice. I'll have to extract the hardcoded strings first but then I can add those translations as well.

Related: #40

Lyhtande commented 4 months ago

I will create a fork and then a pull request, let's see when I'll find the time ;)

wookiefriseur commented 4 months ago

Thx a lot!

I'll release it in a few days. Currently extracting some more hardcoded strings.

Lyhtande commented 4 months ago

If you have some new strings to translate, let me know, I will then add them.

wookiefriseur commented 3 months ago

Most of your translations are live now with #147 @Lyhtande , thanks again :)

We managed to get many of the location strings from the game, so those don't have to be translated anymore.

Let me know if you find any missing ones. Closing this now