search

manavortex / FurnitureCatalogue

FurnitureCatalogue
4 stars 9 forks source link

Merge items that are sold by multiple traders #66

Closed wookiefriseur closed 4 months ago

wookiefriseur commented 1 year ago

Some items are sold by multiple vendors and in different locations. Update tool tips to reflect that.

We can merge some common furniture from the Home Goods Furnishers like: common furniture

Currently we add some furniture multiple times and the most recent DB entry wins and overwrites the others. Example: Rohzika being overwritten rohzika

manavortex commented 1 year ago

I tried grouping some of them by type-of-vendor, but it wasn't so simple as that, because naturally it doesn't much follow any logic what's sold where. Not "Grocer, Zone 2" or "Grocer, Daggerfall Covenant" or "Grocer, Zone Starting With A" :( In the end, I just went with "fuck it, the player will want to know where to buy this item, so give them one reliable source"

wookiefriseur commented 1 year ago

Yeah, I'll keep that issue in mind when reworking the DB structure.

It is also nice how ZOS kept changing sources or IDs. 💩

manavortex commented 1 year ago

Do love that, yeah 😬 Consistency? Never heard of 'er

It's probably easiest to add a flag to the data if it's shared by multiple vendors. Or hold a list of IDs that are sold by... IDK. Nothing of this is easy. :D

wookiefriseur commented 4 months ago

Was able to instead group most of the traders (with some leftovers). 

  AF = GetString(SI_FURC_TRADERS_AF), -- Achievement Vendor: Lozotusk, ...
  BGF = GetString(SI_FURC_TRADERS_BGF), -- Battlegrounds Furnishers
  CAF = GetString(SI_FURC_TRADERS_CAF), -- Main Achievement Vendor: Nolenowen, ...
  EVENT = GetString(SI_FURC_TRADERS_EVENT), -- Event Merchant, any capital city: The Impressario
  HGF = GetString(SI_FURC_TRADERS_HGF), -- Home Goods Furnisher: Maladiq, Rohzika, ...
  HOLIDAY = GetString(SI_FURC_TRADERS_HOLIDAY), -- Heralda, Tildannire, ...
  LUXF = GetString(SI_FURC_TRADERS_LUXF), -- Luxury Furnisher: Zanil

The item overlap affects only Home Goods Furnishers and the itemsource tells the users, where they can get it 100% from. Additional sources aren't important, as you said.

Works for now, until ZOS decides to change everything 😁, version is live in #147

Closing :)