manbeardgames / DiscerningEye

Gathering Companion App For FFXIV
0 stars 0 forks source link

Use Windows built in UI elements/theme #12

Open nakomaru opened 8 years ago

nakomaru commented 8 years ago

Windows already comes with UI elements appropriate to the user's operating system and theme. Mahapp.Metro apps look and run poorly, especially with DWM disabled. Consider using base Windows elements/theme for the UI.

manbeardgames commented 8 years ago

Originally i went with Mahapps because I wanted a "modern" UI theme without having to go through the hassle of creating the resources for UI elements. I've uses Mahapps in the past and was familiar with it, so it was a first choice.

The default UI theme used in WPF applications are decent enough, but they just look like a fancier version of a WinForm application unless you do extensive editing to the templates.

I'll look into adding the option to disable the Mahapps theme within the UI, however, there are a few areas this will be troublesome. One is some of the controls used on the UI come from the Mahapps framework and are not part of default UI elements in WPF. Another is the "night" mode option. This relies on how the Mahapps framework swaps between BaseDark and BaseLight themes.. Since it's all built into that framework, it's just a simple line of code to change it. Removing the framework and keeping this option would be an extensive amount of work that would have to be done to the default UI templates

There are some other things that are taking priority over doing this at the moment, and I hope you understand it. I need to get fishing data in, which means importing and working with the weather algorithms. There are also some issues with how XIVDB filters items, which leaves some of them out of the import when i pull them down for the gathering dictionary. I'm also missing some data that I need to collect on things like locations, and other info not yet present in the app like blue/red scrip rewards and min/med/max collectability

nakomaru commented 8 years ago

Absolutely understandable! This is a minor UI enhancement for a minority of users, and should take a far back seat to big things like fishing.