Bookmarklet doesn't work on docker

manbearwiz / youtube-dl-server

Web / REST interface for downloading youtube videos onto a server.

MIT License

879 stars 284 forks source link

Bookmarklet doesn't work on docker #186

Open jacob2020baklas opened 7 months ago

jacob2020baklas commented 7 months ago

the bookmarklet produced http request does't go past the browser

i think it needs ssl support now it uses vpn and im not sure how to configure it behind my proxy PS: everything else works as expected (UI & Download)

jacob2020baklas commented 7 months ago

Update : i modified the CMD which starts the unicorn server and rerun the container with docker compose

i added --certfile and private key arguments this enabled ssl support but the CORS problem still an issue because starlette-middleware class is missing to solve this we need to add https://www.starlette.io/middleware/#corsmiddleware

manbearwiz commented 7 months ago

yeah its been a long time since I tried the bookmarklet... I don't think adding the CORS middleware to starlette will fix that issue. I think adding that middleware would just allow you to load resources from other domains when on the youtube-dl ui. You might just need to use one of the browser extensions that let you toggle CORS on a page.

manbearwiz commented 7 months ago

try this? https://github.com/balvin-perrie/Access-Control-Allow-Origin---Unblock