manchesergit / material-ui

React Components that Implement Google's Material Design.
http://www.material-ui.com
MIT License
0 stars 0 forks source link

Fix and Test dialog esc key handling #176

Open djbuckley opened 7 years ago

djbuckley commented 7 years ago

When overrideModalEscKey is populated with true, the dialog window should not close when escape is pressed

mak66 commented 7 years ago

Parking this for now as having difficulty getting a Dialog to render with emzyme to be able to test the key esc event handling. Need to review once we have more experience using the tools available and potentially rework Dialog so that it will render.

mak66 commented 7 years ago

Had another look at this and decided the area needs a bit of rework as the overrideModalEscKey property is a little ambiguous and does not align with the disableEscKeyforDialogs property on DatePicker. Changes required...

mak66 commented 7 years ago

Waiting on WIP tasks on Dialog and datePicker completing