Customization for AddNewRowForm Buttons/Text v1.1.3

[GoogleCodeExporter]

By default the oConfirmRowAddingButton and oCancelRowAddingButton are added 
directly to the oAddNewRowForm.  I have made a minor customization that will 
now add these buttons by default to the form dialog instead.

This change allows for a much cleaner form and also allows for better jquery ui 
theming 

I have also added two additional options sAddNewRowOkButtonText & 
sAddNewRowCancelButtonText which will allow a developer to override the default 
"Ok" and "Cancel" button text.

I have attached the updated code to this issue.

Original issue reported on code.google.com by chad.gra...@dominionenterprises.com on 12 May 2011 at 3:26

Attachments:

• jquery.dataTables.editable.js

[GoogleCodeExporter]

Original comment by joc...@gmail.com on 12 May 2011 at 4:21

• Changed state: Started
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Hi Chad,

Thanks for your updates - changes you have made in the plugin was usefull. You 
are right about the injecting buttons in the popup your code is better and I 
have included it in the latest version of the plugin.
However, I have not added text labels exactly as in your example. Now, you can 
set options for each of the buttons e.g:

                            oAddNewRowOkButtonOptions: {
                label: "Confirm",
                                icons: { primary: 'ui-icon-check' },
                                name: "action",
                                value: "add-new"
                            }
If these properies are set instead of the plain button will be generated JQuery 
UI buttons. Properties label and icons are properties that will be set to the 
JQuery UI buttons that will be generated, other properties will be just added 
to the generated button.
You can see example of customization here 
http://jquery-datatables-editable.googlecode.com/svn/trunk/customize-buttons.htm
l.
Could you please get the version 1.1.7. and let me know does it works fine in 
your code. I hope that removing sAddNewRowOkButtonText and 
sAddNewRowCancelButtonText will not cause to much changes in your code.

Thanks,
Jovan

Original comment by joc...@gmail.com on 13 May 2011 at 6:29

[GoogleCodeExporter]

Jovan,

The changes work great.  We will continue to use and promote the use
of your plugin. My team and I are very grateful for your quick
response and if at anytime you need assistance with the development of
the plugin do not hesitate to ask.

Thanks again
Chad

On Fri, May 13, 2011 at 2:30 AM,
<jquery-datatables-editable@googlecode.com> wrote:

Original comment by chad.gra...@dominionenterprises.com on 13 May 2011 at 2:44

[GoogleCodeExporter]

Hi Chad,

I'm glad that it works and that it helps you. Regarding the development any
idea or even better a working code is appreciated, so if you find any useful
feature that might be integrated you can send me a code and I will add it to
the main version.
I have few ideas and it would be great if you can take some of them and see
how they can be implemented. Examples are:
1. On the DataTables site there is a KeyTable plugin that allows you to
navigate through the table in the excel like manner, and it can be
integrated with jEditable see
http://www.datatables.net/release-datatables/extras/KeyTable/editing.html.
You might try to integrate this plugin with key table. Somehow should be
detected whether the keytable is already applied to the data table and if
so, in the plugin should be applied some code like the one on the data
tables site.
2. Currently plugin supports just a basic jEditable editors text box, text
area and select list. In the future will be added support for additional
types such as check boxes (http://www.pastie.org/893364), jquery ui
calendars, or some existing custom editors like time pickers or even file
uploads (see example on the
http://www.appelsiini.net/projects/jeditable/custom.html). You might try to
integrate some of them into the plugin.
3. Currently in the server-side mode each time cell is edited rows are
reloaded from the server side (because dataTables need to calculate where
the row with an edited cell should be placed in the table). This reload can
be prevented but somehow should be determined whether the cell can stay in
the current position so reload will not be required (e.g. if table is
already sorted by any other column row will keep the current position).

If you find any other interesting feature or maybe a bug you can also take a
look at this.

I will add these features to the issue list so if you find any feature you
like you can put comment there that you are investigating it.

Original comment by joc...@gmail.com on 13 May 2011 at 4:34

[GoogleCodeExporter]

Original comment by joc...@gmail.com on 28 May 2011 at 1:49

• Changed state: Fixed