search

mandarons / icloud-drive-docker

Dockerized iCloud Client - make a local copy of your iCloud documents and photos, and keep it automatically up-to-date.
BSD 3-Clause "New" or "Revised" License
985 stars 47 forks source link

[FEATURE] Allow downloading all albums #128

Closed tymmej closed 9 months ago

tymmej commented 1 year ago

Describe the bug Downloading photos without filters["albums"] downloads only main (pseudo)folder with all photos.

Logs show misleading information:

2023-02-24 19:14:49,881 :: WARNING :: root :: config_parser.py :: 287 :: photos > filters > albums not found. Downloading all albums ...

It's Downloading "all" album where "all" is (pseudo)album, not all albums which are user created albums.

To Reproduce Run docker without without filters["albums"] on library with user defined albums.

Expected behavior Without filter["albums"] download all albums as log suggests. Alternatively, allow "*" in filter["albums"] to really download all albums.

Screenshots Not applicable.

Configuration As described in previous points.

Additional context Similar loop to https://github.com/mandarons/icloud-drive-docker/blob/33d5683aa22e106c8e9de0985c8bf49117bc4a36/src/sync_photos.py#L116 should be added to else path with for album in photos.albums.keys(). Or another option is to do that in first path under * wildcard in config.

Storage is cheap, I don't care about duplication of photos which are in multiple albums (All, Favorites, grouped by event, Live Photos...).

tymmej commented 1 year ago

In #130 I added version without unit tests. As I said I do not know how to mock data for Smart Albums.