search

mandarons / icloud-drive-docker

Dockerized iCloud Client - make a local copy of your iCloud documents and photos, and keep it automatically up-to-date.
BSD 3-Clause "New" or "Revised" License
969 stars 46 forks source link

Unique filenames #148

Closed tymmej closed 6 months ago

tymmej commented 10 months ago

Contains #146 as otherwise that option isn't useful.

mandarons commented 9 months ago

Does this PR make #146 and #145 obsolete?

tymmej commented 9 months ago

This PR contains them.

I split them to smaller chunks to reduce scope and allow smaller merges.

mandarons commented 9 months ago

@tymmej When all_albums is true, it will create nested folders for each album. That will create unique paths for photos that are present with same name in multiple albums.

@tymmej Why do we need this PR?

tymmej commented 9 months ago

I'm using downloaded photos with https://github.com/photoview/photoview

Photoview has bug (or maybe it's intentional?) that photos in database are stored only by filename - not full path. So it doesn't work with multiple files with same filename, but in different folders. Photoview displays folders as albums in web view, but if same photo is added to multiple albums in iCloud then it's visible only in one album in web view. Adding this option allows to show photo in all albums.

mandarons commented 9 months ago

@tymmej: Okay. Yeah, I remember this use case. This is a one-off use case and doesn't matter for broader user base of this tool. I am not planning to spend any time in maintaining one-off use cases at this point. However, I can get this feature in, given that it is enabled by a flag in config and how important it is to you.

Going forward, would you like to be the maintainer of this feature?

tymmej commented 9 months ago

What "maintainer" does mean in this context?

Can this pull request wait? Immich made some progress with read-only libraries (https://documentation.immich.app/docs/features/libraries). It is not ideal at the moment - it doesn't create albums from folders, but maybe it will be added (https://github.com/immich-app/immich/discussions/4279). Also it seems that Immich has larger user base so I'm planning to migrate to it.

mandarons commented 9 months ago

@tymmej Maintainer for a feature is typically a go to person to get help from, should any issue arise in using the feature (i.e. helping with resolving bugs related to the feature).

Yeah, this PR can certainly wait. I only heard good things about immich. It seems to be trending to the top in FOSS photos management and being very actively developed. I certainly recommend migrating to immich.