search

mandarons / icloud-drive-docker

Dockerized iCloud Client - make a local copy of your iCloud documents and photos, and keep it automatically up-to-date.
BSD 3-Clause "New" or "Revised" License
969 stars 46 forks source link

[FEATURE] Support all photo versions in photo filter #188

Closed Chaldron closed 1 month ago

Chaldron commented 4 months ago

icloudpy supports a number of photo versions (original, thumbnail, etc. see here), but get_photos_filters in config_parser.py only permits "original", "medium", and "thumb". I have built the image locally to accept all versions supported by icloudpy, and I can confirm that it correct downloads the "original_alt" files (which in my case happen to be RAW files). I think an easy solution is to just duplicate the list used in icloudpy, but maybe a better way is for icloudpy to expose which versions it supports so clients can refer to it. I'd be happy to put up PRs for either of these methods. By the way, thank you for developing this very useful project :)

Log output:

icloud-sync  | 2024-02-10 04:40:19,350 :: WARNING :: root :: config_parser.py :: 340 :: Skipping the invalid file size original_alt, valid file sizes are original,medium,thumb.
mandarons commented 4 months ago

@Chaldron Please feel free to submit PR(s).