Peer-to-peer code review

mandelatuks / mandela_adebowale-trial-microverse

trial

Other

0 stars 0 forks source link

Peer-to-peer code review #2

Open Ursaaaaaa opened 2 years ago

Ursaaaaaa commented 2 years ago

Hello @mandelatuks 👋 you did Amazing work 🥇 . Clean Code 👍 . Github workflow 👍 . Here are some best practices maybe you can implement to improve your code.

Form fields have no labels, it would be good practice to add labels to your form
It would be great if you used semantic tags
Your commit messages should be more descriptive and precise
Also it is best practice to begin committing messages with caps so kindly consider that in subsequent commits

khitermedachraf commented 2 years ago

[x] Great Code review.👋 🥇

keep it up.👍

khitermedachraf commented 2 years ago

Congratulations! 🎉

To Highlight

All linters are passing ✔️
Descriptive commit messages ✔️
Professional looking pull request ✔️
Your readme looks professional ✔️
Good overall design ✔️
Your code is clean and well documented ✔️