mandiant / VM-Packages

Chocolatey packages supporting the analysis environment projects FLARE-VM & Commando VM.
Apache License 2.0
123 stars 61 forks source link

Move Removal of `map.vm` Right Click "Cmd Here" option from "map.vm" to "windows-terminal.vm" #1002

Open emtuls opened 2 months ago

emtuls commented 2 months ago

Details

As of https://github.com/mandiant/VM-Packages/pull/983, we opted to remove the right click "Cmd Here" that map.vm introduces when installing due to favoring the right click for opening with Windows Terminal instead.

But, we placed this removal code inside of the map.vm package, which means that if a user wants map.vm and wants to retain this right click option, but does not add windows-terminal.vm to their list of packages, they would have no Right Click "Cmd Here" option available to them automatically.

I think the removal of the Right Click "Cmd Here" added by map.vm is better suited inside of the windows-terminal.vm package, as that is where we are essentially replacing the right click option, and would give uses the ability to keep the one added by map.vm if they wanted to only use that package.