mandiant / VM-Packages

Chocolatey packages supporting the analysis environment projects FLARE-VM & Commando VM.
Apache License 2.0
123 stars 61 forks source link

Remove Chrome dependency in cyberchef.vm thank to new changes #1021

Open Ana06 opened 2 months ago

Ana06 commented 2 months ago

Details

I think with the changes in https://github.com/mandiant/VM-Packages/pull/1016 we could now remove the Chrome dependency in Cyberchef and the code to open it with chrome and set the icon (simplifying the installer code). I think we would keep the current behavior if both cyberchef.vm and googlechrome.vm are installed and remove the chrome dependency would allow to have a different browser as default (and to open cyberchef) if only cyberchef.vm is installed. This would need to add googlechrome.vm explicitly in flare-vm.

@emtuls what do you think?

emtuls commented 1 month ago

@Ana06 Looking at this some more, I can't get a .html to open up with the specified browser using the VM-Set-Open-With-Association unfortunately. This runs into the same issue we had previously where it requires modification of a few specific registry keys that can't be changed unless the proper hash is generated and placed in the right location (along with a few other tweaks). In this case, it shows that it wants to open the file using Google Chrome, but then still displays the popup of if we want to always associated .html with this browser still, which can be seen in the screenshots below, which I'm not sure if this is preferred.

To bypass this, we can attempt to use the tool we discussed here, called SetDefaultBrowser, but I'll leave that up to you to determine if that's acceptable. :)

image

image

Ana06 commented 1 month ago

VM-Set-Open-With-Association $exePath ".html" changes the icon but not the default icon, right? I think this is confusing, we should change the icon of html + default browser or remove the icon association. Let's discuss in https://github.com/mandiant/VM-Packages/issues/822 if we can change the default browser.