search

mandiant / VM-Packages

Chocolatey packages supporting the analysis environment projects FLARE-VM & Commando VM.
Apache License 2.0
122 stars 61 forks source link

Add 1603 to validExitCodes #1068

Closed naacbin closed 3 weeks ago

naacbin commented 3 weeks ago

This should avoid exiting in error when dokan is already installed. #1063

naacbin commented 3 weeks ago

The dokan packages doesn't use the helper in common or am I missing something? If it is possible to adapt dokan to use the helper would be good.

We can't as category is mandatory to use the helper. However, I will add the validExitCode variable to the chocolatey installer function.

Ana06 commented 3 weeks ago

@emtuls I think we can add also the exit codes to googlechrome.vm and remove the -ErrorAction SilentlyContinue and VM-Assert-Path $exePath which we added because the MSI installer failed to install if the tool was already installed (which should fail with code 1603): https://github.com/mandiant/VM-Packages/blob/715d55a3d23dbbc1181a3fc782f898751b5a786a/packages/googlechrome.vm/tools/chocolateyinstall.ps1#L23C51-L23C80