Fix the calls to VM-Uninstall-With-Uninstaller

mandiant / VM-Packages

Chocolatey packages supporting the analysis environment projects FLARE-VM & Commando VM.

Apache License 2.0

122 stars 61 forks source link

Fix the calls to VM-Uninstall-With-Uninstaller #1088

Closed d35ha closed 2 weeks ago

d35ha commented 2 weeks ago

Closes https://github.com/mandiant/VM-Packages/issues/1055.

d35ha commented 2 weeks ago

I think we should avoid updating the metasploit package at the moment due to Fix Metasploit #828 (@Ana06 may be able to give a better recommendation, as I'd hate to have this package still be incorrect)

@emtuls Solved at https://github.com/mandiant/VM-Packages/pull/1091.

d35ha commented 2 weeks ago

npcap.vm is missing the $category piece

Npcap doesn't have a shortcut installed under ${Env:TOOL_LIST_DIR}\$category.

d35ha commented 2 weeks ago

we may want to possibly try to address the issue noted here: Fix calls to VM-Uninstall-With-Uninstaller which miss category #1055 (comment)

@emtuls Solved at https://github.com/mandiant/VM-Packages/pull/1088/commits/5c9f628a32df43e0a38894e811fa650d6c553c7e.

d35ha commented 2 weeks ago

@Ana06 This PR is depending on https://github.com/mandiant/VM-Packages/pull/1091, will rebase once it's merged.

emtuls commented 2 weeks ago

@d35ha https://github.com/mandiant/VM-Packages/pull/1091 has been merged. You're good to go now!

d35ha commented 2 weeks ago

@emtuls Thanks, it's ready now.