Confusing `unzip "infected"` with wrong password

mandiant / VM-Packages

Chocolatey packages supporting the analysis environment projects FLARE-VM & Commando VM.

Apache License 2.0

144 stars 64 forks source link

Confusing `unzip "infected"` with wrong password #1135

Open Ana06 opened 1 month ago

Ana06 commented 1 month ago

Details

Show error when using unzip "infected" if the password is wrong. If the ZIP is not password protected and you use the unzip "infected" option, it still extracts the ZIP correctly. But if it is password protected and the password is not infected, then the files may be extracted and be empty, which is very confusing. Research displaying an error and/or not extracting the files in this case. @mandiant/vms ideas?

mr-tz commented 1 month ago

Can we check the return code for success/fail?