Fix broken memprocfs download link

mandiant / VM-Packages

Chocolatey packages supporting the analysis environment projects FLARE-VM & Commando VM.

Apache License 2.0

140 stars 62 forks source link

Fix broken memprocfs download link #954

Closed citharus closed 6 months ago

citharus commented 6 months ago

The download link of the 5.8.17 version does not exist anymore and has to be replaced with the newest release 5.9.3. I updated the version in the nuspec, the zipUrl and zipSha256. I tested it on my own VM and after the changes the package installed with no problems.

(I did not create an Issue because it was in the Daily Failures)

google-cla[bot] commented 6 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

naacbin commented 6 months ago

Thanks for the PR @citharus ! However, I don't think we should use the URI you provide as the versions are archived quickly. So, the last version we can get to work is : https://github.com/ufrisk/MemProcFS/releases/download/v5_archive/MemProcFS_files_and_binaries_v5.9.4-win_x64-20240318.zip

Could you change you PR accordingly ? Also could you please squash your commits (in order to maintain a clean commit history) ?

naacbin commented 6 months ago

LGTM, I've tested and it works well.