I updated a couple of commands that were not working in their current state.
Most packages needed -innerFolder added to them.
I updated the way we use -withoutBinFile. The current way we used it forced the tool to have .exe, which doesn't always make sense, especially when the flag is for 'without a binary file'. I take this to mean that the tool does -not- have any .exe associated with it (or we do not want the .exe associated with the shortcut), which was the case for many tools that are used in CommandoVM. By separating it into its own if statement, I think it brings more clarity into how we are using it and its intent.
All changed tools have been tested and work just as the original way they were set as, before any changes, other than ones previously broken, which are now fixed.
This completes step 1 of https://github.com/mandiant/VM-Packages/issues/749
I updated a couple of commands that were not working in their current state.
Most packages needed
-innerFolderadded to them.I updated the way we use
-withoutBinFile. The current way we used it forced the tool to have.exe, which doesn't always make sense, especially when the flag is for 'without a binary file'. I take this to mean that the tool does -not- have any.exeassociated with it (or we do not want the.exeassociated with the shortcut), which was the case for many tools that are used in CommandoVM. By separating it into its own if statement, I think it brings more clarity into how we are using it and its intent.All changed tools have been tested and work just as the original way they were set as, before any changes, other than ones previously broken, which are now fixed.