Load .json.gz files directly

mandiant / capa

The FLARE team's open-source tool to identify capabilities in executable files.

https://mandiant.github.io/capa/

Apache License 2.0

4.07k stars 512 forks source link

Load .json.gz files directly #1990

Closed Rohit1123 closed 6 months ago

Rohit1123 commented 6 months ago

closes #1883

For loading .json.gz files directly, used the code from tests:

https://github.com/mandiant/capa/blob/0f9dd9095b04c844fd3b1923ec8eb6241e7252b5/tests/fixtures.py#L193

Checklist

[ ] No CHANGELOG update needed
[ ] No new tests needed
[x] No documentation update needed

google-cla[bot] commented 6 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mr-tz commented 6 months ago

and please add an entry in the changelog so we can recognize your work!

Rohit1123 commented 6 months ago

@mr-tz, thanks for the feedback. I've added a test and made an entry in change log. And lint with ruff is failing because json is imported but unused in capa/loader.py. May I discard import json?

mr-tz commented 6 months ago

yes, please