mandiant / capa

The FLARE team's open-source tool to identify capabilities in executable files.
https://mandiant.github.io/capa/
Apache License 2.0
4.14k stars 522 forks source link

Display analysis information #2134

Open s-ff opened 3 months ago

s-ff commented 3 months ago

Closes #857.

This commit introduces two new metadata fields to result_document. Would this be considered a breaking change?

This would require regenrating the rdoc test files. see https://github.com/mandiant/capa-testfiles/pull/239.

Checklist

mr-tz commented 3 months ago

I think this requires regenerating the files in tests/data/rd/

s-ff commented 3 months ago

Should be good to go once https://github.com/mandiant/capa-testfiles/pull/239 is merged.

mr-tz commented 3 months ago

Stepping back here for a moment, let's consider if we want to implement this differently:

That way we can handle the various limitations/warnings consistently. The core extraction logic still resides in capa but we don't have to extend the meta data.

Related: should we provide functionality to easier leverage this in other tools? Right now other tools need to reimplement the logic we have in capa.main to handle special cases/detections.

williballenthin commented 3 months ago

@mr-tz this would require many fewer breaking changes, which i like