search

mandiant / commando-vm

Complete Mandiant Offensive VM (Commando VM), a fully customizable Windows-based pentesting virtual machine distribution. commandovm@mandiant.com
https://www.mandiant.com/resources/blog/commando-vm-windows-offensive-distribution
Apache License 2.0
6.87k stars 1.28k forks source link

Simplify boolean expression #310

Open rsdoherty opened 10 months ago

rsdoherty commented 10 months ago

There's a fair bit of code in here that's evaluating boolean expressions and returning the opposite value, when you can reverse the comparison and just return that directly.

This PR updates a few of the statements to use that behaviour 👍

google-cla[bot] commented 10 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

geo-lit commented 4 months ago

@rsdoherty thank you for the help with the project. Please sign the Google CLA so that we can merge your commit.