mandiant / flare-ida

IDA Pro utilities from FLARE team
Apache License 2.0
2.24k stars 464 forks source link

idb2pat: fix wrong variable preventing to calculare CRC16 and tail bytes #71

Closed invano closed 5 years ago

invano commented 5 years ago

Commits 2f0a449 and 21ad641 introduced variable loc to act as a pointer while building the pattern. The loop consuming the CRC bytes uses i instead, causing loc to always be equal to 32. If loc==32 then both CRC16 and tail bytes are skipped.

williballenthin commented 5 years ago

thank you!