mandiant / flare-vm

A collection of software installations scripts for Windows systems that allows you to easily setup and maintain a reverse engineering environment on a VM.
Apache License 2.0
6.37k stars 900 forks source link

Fix not detecting stock VMWare/Hyper-V installations. #438

Closed shavitush closed 1 year ago

shavitush commented 1 year ago

While installing on my VM (VMWare Workstation 17 Pro, Windows 10 Pro 64-bit 22H2), I've noticed how the installer was thinking my VM is hardened.

image

In my case, the computer system model was "VMWare20,1" which wouldn't pass the string equation of == "VMware Virtual Platform" of course.

This PR fixes the bug by checking if the computer system model contains any of the specified models, as well as changing the string of VMware's model to "VMware" to ensure success in all cases.

In addition, I've also added Hyper-V's model.