mandiant / flare-vm

A collection of software installations scripts for Windows systems that allows you to easily setup and maintain a reverse engineering environment on a VM.
Apache License 2.0
6.35k stars 896 forks source link

Adding check for usernames with spaces #485

Closed HuskyHacks closed 1 year ago

HuskyHacks commented 1 year ago

Adding a small check in the install script that will detect spaces in usernames and exit gracefully if one is identified:

Detecting a space and exiting: 2023-08-24 13_48_16-go-101-win - VMware Workstation

...and continuing with the installation if the username looks good: 2023-08-24 13_45_51-go-101-win - VMware Workstation

... and this check is encapsulated in the block of the rest of the checks, so the -noChecks param will bypass it, even if the username is non-compliant: image

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.