search

mandiant / flare-vm

A collection of software installations scripts for Windows systems that allows you to easily setup and maintain a reverse engineering environment on a VM.
Apache License 2.0
6.22k stars 887 forks source link

Download config.xml directly to %VM_COMMON_DIR% instead to the Desktop #540

Closed Ana06 closed 8 months ago

Ana06 commented 8 months ago

Details

I think we shouldn't download the config file to the desktop, but directly to ${Env:VM_COMMON_DIR} as we do with other configuration downloads like the background image. This requires to adapt some checkings and errors messages in the installer.

Related to https://github.com/mandiant/flare-vm/issues/537

@mandiant/flare-vm opinions?

Ana06 commented 8 months ago

Issue: %VM_COMMONDIR% is at the moment created in common.vm which needs the config