search

mandiant / gocrack

GoCrack is a management frontend for password cracking tools written in Go
MIT License
1.12k stars 240 forks source link

Improve ssl certificate error reporting #16

Closed recon-ng closed 6 years ago

recon-ng commented 6 years ago

When gocrack_server parses the configs/server.yaml config, it throws the same error when encountering issues with the ca certificate, child certificate, and email server certificate. This makes it difficult to troubleshoot certificate issues.

tankbusta commented 6 years ago

Unfortunately I just return the error that Go returns unless the CA certificate is not valid, then I just throw a generic error. You can see the relevant code here: https://github.com/fireeye/gocrack/blob/master/shared/tls.go#L13

Can you get an example of the error you were getting from an invalid certificate?

tankbusta commented 6 years ago

I've improved the SSL errors by indicating what config directive has the invalid data