search

mandiant / gocrack

GoCrack is a management frontend for password cracking tools written in Go
MIT License
1.12k stars 240 forks source link

Timer function #32

Closed croustibaie closed 6 years ago

croustibaie commented 6 years ago

Added a timer function. The timer is added in the "Task structure".

While creating a new task, add a "task_duration" variable to the json.

tankbusta commented 6 years ago

@croustibaie Do you want me to add this new field to the UI component? I should be able to add it pretty quickly so we can get this out the door :)

croustibaie commented 6 years ago

It would be awesome if you could add this to the UI! I'm actually far from being a dev and I have very few knowledge of node.js.

tankbusta commented 6 years ago

Awesome, this looks good. I'll get the UI portion done today, do some testing, and merge it!

tankbusta commented 6 years ago

Alright, I was able to create a component for the time limit code here.

It took a little longer than expected as I noticed a bunch of things were broken when I upgraded to the release build of Bootstrap 4, so I had to fix all those issues too. I should be able to test this and the LDAP fix you reported tomorrow

croustibaie commented 6 years ago

Great! Thanks a lot. Tell me if there is anything else I can do.

I noticed Yesterday that connecting with a mix of upper and lower case letters while using the LDAP connector creates new accounts. Maybe lower casing the username in the LDAP authentication module could be nice. Still, some people could be using a case sensitive LDAP, so I am not really sure whether this is an issue or not.

tankbusta commented 6 years ago

Thanks for the contribution!

I'll ask around if case-sensitive LDAP is a thing otherwise we can look at strings.ToLower(). It looks like it's very rare according to https://stackoverflow.com/questions/29897684/is-ldap-dn-case-insensitive

tankbusta commented 6 years ago

The UI portion was merged in if you want to pull it down and give it a try in your deployment :)

croustibaie commented 6 years ago

Hi, Thanks a lot, i'm testing it right away.