search

mandiant / gocrack

GoCrack is a management frontend for password cracking tools written in Go
MIT License
1.12k stars 240 forks source link

Proposal: Move gocat to its own repository #50

Closed jmmcatee closed 5 years ago

jmmcatee commented 5 years ago

I have been working on some changes to gocat to support v4 and now looking at v5 and I think it might be helpful to have a separate repository just for it. Any interest in pull it out similar to the UI repository?

tankbusta commented 5 years ago

I'd prefer to keep it in this repo if it works for you. If you're working on a fork, just make sure all the work is in a branch named feat/update_hashcat_to_v5 and we can PR it in here when you're done.

Is there major changes in v5 that really breaks things?

jmmcatee commented 5 years ago

Have not gotten too much into it yet so not sure. I have v4 working pretty well in my local tests and looking to use gocat to replace my current plugin for hashcat in github.com/jmmcatee/cracklord. Thanks for the consideration.

tankbusta commented 5 years ago

Let me think about it some more and see what it'd take. I have to involve other people to create repo's and get it approved... When this was an internal FireEye project, it was actually separate and would certainly make it easier to support other versions of Hashcat.

jmmcatee commented 5 years ago

Supporting multiple versions was definitely one of the reasons as I'm not sure it will be easy to have one version that supports multiple hashcat versions, but my familiarity with cgo is limited.

tankbusta commented 5 years ago

@jmmcatee We will be moving gocat into it's own repository that will make it easier for contributions and use in other open source software.

It'll live in https://github.com/fireeye/gocat