search

mandli / intro-numerical-methods

Jupyter notebooks and other materials developed for the Columbia course APMA 4300
Creative Commons Attribution 4.0 International
278 stars 398 forks source link

Error in Golden Search Derivation #50

Closed xl2604 closed 7 years ago

xl2604 commented 7 years ago

c = a^2 / b → a / b = a^2 / [b (b - a^2 / b)] a / b = a^2 / (b^2 - a^2) (there's an extra factor of 1 / b^2 in the notes)

mandli commented 7 years ago

I have fixed this specific issue but I believe the source I have taken this from may have an inconsistency in the derivation. I have rewritten this section and now have a new version up and would appreciate feedback from @x94carbone and @xl2604 to see if this answers your questions before we close this issue.

matthewcarbone commented 7 years ago

It looks good to me. The usage of the golden ratio and pseudo-code algorithm are correct to my knowledge. Thanks for addressing this! What do you think @xl2604?

xl2604 commented 7 years ago

Having checked the new version carefully. Looks good to me too!

mandli commented 7 years ago

Great! Thanks to you both for making the notes better.