search

mandli / intro-numerical-methods

Jupyter notebooks and other materials developed for the Columbia course APMA 4300
Creative Commons Attribution 4.0 International
278 stars 398 forks source link

Changes to verbiage and adding small bits to the introductory notebook #61

Closed KellyBlack closed 5 years ago

mandli commented 5 years ago

Interesting, scipy.misc.factorial is deprecated and is instead in scipy.special.factorial. Can you make that quick change in 04_error.ipynb? Given that Python 2.x support is being dropped by numpy and scipy we may want to remove the testing for 2.7 but maybe we can ignore that for now.

KellyBlack commented 5 years ago

I just changed the way factorials are calculated in the 04_error.ipynb notebook. Rather than use scipy I converted it to use numpy. I had to explicitly cast the result of the factorial function to a float32 in the existing function.

mandli commented 5 years ago

Thanks!