search

mandolyte / mdtopdf

Markdown to PDF
MIT License
135 stars 33 forks source link

Update mdtopdf.go #24

Closed prasannahanu closed 1 year ago

prasannahanu commented 1 year ago

Looks like Code styling declaration is missed ... sorry about that, Can u please approved and merged ... thanks

mandolyte commented 1 year ago

@prasannahanu done!

prasannahanu commented 1 year ago

Are latest pull requests not merged to v1.3.0 version ? Need to merge pull requests #23 and #24 into latest v1.3.0 release ... thx

When I get latest version, I am still seeing old code and giving error since latest updates are missing

go: github.com/mandolyte/mdtopdf upgrade => v1.3.0

github.com/mandolyte/mdtopdf

/Users/prasanna/code/go/pkg/mod/ @.***/nodeProcessing.go:32:33: syntax error: unexpected r, expecting comma or )

/Users/prasanna/code/go/pkg/mod/ @.***/nodeProcessing.go:234:33: syntax error: unexpected r, expecting comma or )

On Tue, Mar 14, 2023 at 9:32 PM Cecil New @.***> wrote:

@prasannahanu https://github.com/prasannahanu done!

— Reply to this email directly, view it on GitHub https://github.com/mandolyte/mdtopdf/pull/24#issuecomment-1469134245, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5SAHSGXGTXS7ZXZWPJWIT3W4EL27ANCNFSM6AAAAAAV2SSDRM . You are receiving this because you were mentioned.Message ID: @.***>

mandolyte commented 1 year ago

Thanks, I forgot to do a new release... there is now a patch release v1.3.1

Cecil

On Thu, Mar 16, 2023 at 10:59 AM prasannahanu @.***> wrote:

Are latest pull requests not merged to v1.3.0 version ?

When I get latest version, I am still seeing old code and giving error since latest updates are missing

go: github.com/mandolyte/mdtopdf upgrade => v1.3.0

github.com/mandolyte/mdtopdf

/Users/prasanna/code/go/pkg/mod/ @.***/nodeProcessing.go:32:33: syntax error: unexpected r, expecting comma or )

/Users/prasanna/code/go/pkg/mod/ @.***/nodeProcessing.go:234:33: syntax error: unexpected r, expecting comma or )

On Tue, Mar 14, 2023 at 9:32 PM Cecil New @.***> wrote:

@prasannahanu https://github.com/prasannahanu done!

— Reply to this email directly, view it on GitHub https://github.com/mandolyte/mdtopdf/pull/24#issuecomment-1469134245, or unsubscribe < https://github.com/notifications/unsubscribe-auth/A5SAHSGXGTXS7ZXZWPJWIT3W4EL27ANCNFSM6AAAAAAV2SSDRM

. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/mandolyte/mdtopdf/pull/24#issuecomment-1472145799, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ2ZXMRPPJKZGEJEUI36ZLW4MTGVANCNFSM6AAAAAAV2SSDRM . You are receiving this because you modified the open/close state.Message ID: @.***>