mandolyte / mdtopdf

Markdown to PDF
MIT License
133 stars 32 forks source link

Update nodeProcessing.go #25

Closed prasannahanu closed 1 year ago

prasannahanu commented 1 year ago

Updates to back tick styling to fill in background color for the string

prasannahanu commented 1 year ago

I thought trace log might be helpful for others but we turned off trace.lo, so we can remove that log line if needed, does not matter for us.

I have another question: Is this library supports markdown css styling conversion ?

I am trying to test this in markdown but it does not work and I see HTMLSpan() method is disabled, any suggestion what code changes are needed or may be blackfriay library does not support as well ?

{number}

On Fri, Mar 31, 2023 at 10:38 AM Cecil New @.***> wrote:

@.**** commented on this pull request.

On nodeProcessing.go https://github.com/mandolyte/mdtopdf/pull/25#discussion_r1154559732:

Did you intend on leaving the tracer messages in the code? Pros/Cons?

— Reply to this email directly, view it on GitHub https://github.com/mandolyte/mdtopdf/pull/25#pullrequestreview-1367071228, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5SAHSFQX336JYI4SZX2V4LW63T7JANCNFSM6AAAAAAWNZPLLQ . You are receiving this because you authored the thread.Message ID: @.***>

prasannahanu commented 1 year ago

Sometimes we get errors about png buffer, any suggestions how to fix ? "not a png buffer"

Received err while processing markdown contents, unable to create pdf: Pdf.OutputFileAndClose() error on LearningCenter05e0bf83-371e-4722-8d2b-7572d1fbc0d8.pdf:not a PNG buffer"

On Fri, Mar 31, 2023 at 10:51 AM Prasanna Hanumaihgari < @.***> wrote:

I thought trace log might be helpful for others but we turned off trace.lo, so we can remove that log line if needed, does not matter for us.

I have another question: Is this library supports markdown css styling conversion ?

I am trying to test this in markdown but it does not work and I see HTMLSpan() method is disabled, any suggestion what code changes are needed or may be blackfriay library does not support as well ?

{number}

On Fri, Mar 31, 2023 at 10:38 AM Cecil New @.***> wrote:

@.**** commented on this pull request.

On nodeProcessing.go https://github.com/mandolyte/mdtopdf/pull/25#discussion_r1154559732:

Did you intend on leaving the tracer messages in the code? Pros/Cons?

— Reply to this email directly, view it on GitHub https://github.com/mandolyte/mdtopdf/pull/25#pullrequestreview-1367071228, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5SAHSFQX336JYI4SZX2V4LW63T7JANCNFSM6AAAAAAWNZPLLQ . You are receiving this because you authored the thread.Message ID: @.***>

mandolyte commented 1 year ago

It will be a while before I am able to spend significant time on this tool. Pretty consumed by other projects these days. I do appreciate that you have taken an interest!

I suggest you file your questions as issues. Then as I am able (or as you are able), I can do the research needed to find solutions.

mandolyte commented 1 year ago

@prasannahanu merged... will do a new release next.

prasannahanu commented 1 year ago

thanks will do

On Fri, Mar 31, 2023 at 11:00 AM Cecil New @.***> wrote:

It will be a while before I am able to spend significant time on this tool. Pretty consumed by other projects these days. I do appreciate that you have taken an interest!

I suggest you file your questions as issues. Then as I am able (or as you are able), I can do the research needed to find solutions.

— Reply to this email directly, view it on GitHub https://github.com/mandolyte/mdtopdf/pull/25#issuecomment-1492069188, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5SAHSAYQUQRRBZJJPXKHELW63WQ5ANCNFSM6AAAAAAWNZPLLQ . You are receiving this because you authored the thread.Message ID: @.***>