search

mandolyte / mdtopdf

Markdown to PDF
MIT License
126 stars 31 forks source link

Migrate to gomarkdown #40

Closed jessp01 closed 1 year ago

jessp01 commented 1 year ago

As the BlackFriday project is no longer active, this pull migrates us to gomarkdown

mandolyte commented 1 year ago

@jessp01 In the cmd/md2pdf folder I ran go run md2pdf -i test.md -o test.pdf and found that the md file doesn't have valid references to the image files. They are '../images/xxx' and need another level now that these files are another level deep in the folder structure. Otherwise, looks good! I can make this change after I merge if you wish.

Let me know

jessp01 commented 1 year ago

Hi @mandolyte ,

Yes, that's a relic from when we moved mdtopdf.go into cmd/md2pdf, it's not related to the migration to gomarkdown of course but I fixed it just now.

On a more general level, do you reckon perhaps we should move these resource files (russian.md, test.md, helvetica_1251.json, etc) into a separate directory?

Cheers,

mandolyte commented 1 year ago

@jessp01 Agree... seems to be getting sort of messy in there. And I recall there may be some duplication left in the parent directory.

Migration to the gomarkdown is fairly significant, even if invisible to a user. Deserves at least a semver of 1.6. But wondering if a 2.0 might be appropriate. Thoughts?

jessp01 commented 1 year ago

@mandolyte , obviously, it's your call:) But I agree it's significant, even if I've gone to some lengths to make sure it's not something end users will notice (to wit: to ensure I haven't broken anything). I don't think going with v2.0.0 is unreasonable.

mandolyte commented 1 year ago

Sounds good... will wait until tomorrow... won't have time to release today. Thanks for all the work you have invested!!

jessp01 commented 1 year ago

Cheers, @mandolyte. Most happy to collaborate. It's always nice when the maintainer is sensible, responsive and appreciative:) Not always the case, alas.

Also, I've submitted https://github.com/mandolyte/mdtopdf/pull/41 which removes additional BlackFriday references from the README.