search

mandolyte / mdtopdf

Markdown to PDF
MIT License
135 stars 33 forks source link

Needed changes in light of the creation of v2 #45

Open jessp01 opened 1 year ago

jessp01 commented 1 year ago

Hi @mandolyte ,

Since we're now on v2, some structure changes are required as, when one runs:

go install github.com/mandolyte/mdtopdf/cmd/md2pdf@latest

The received version is v1.5.3, not v2.2.1.

When trying to explicitly install v2.2.1:

$ go install github.com/mandolyte/mdtopdf/cmd/md2pdf@v2.2.1

One would get this message:

go: github.com/mandolyte/mdtopdf/cmd/md2pdf@v2.2.1: github.com/mandolyte/mdtopdf@v2.2.1: invalid version: module contains a go.mod file, so module path must match major version ("github.com/mandolyte/mdtopdf/v2")

Please see https://go.dev/blog/v2-go-modules

Happy to help with the restructure if you'd like.

Cheers,

mandolyte commented 1 year ago

@jessp01 I have a counter proposal... while I love to code and this and other projects were done after I retired, I don't quite see myself spending as much time coding going forward. I also just finished a 3 year stint of working for a non-profit doing web apps with JavaScript. And now my kids have moved to Texas and England. I don't think I'll be doing much coding even tho I enjoy it.

So my counter proposal is this: would you be willing to take over this package? Thanks for your interest and energy!

jessp01 commented 1 year ago

Hi @mandolyte ,

I also just finished a 3 year stint of working for a non-profit doing web apps with JavaScript.

Laudable, indeed.

And now my kids have moved to Texas and England I don't think I'll be doing much coding even tho I enjoy it.

Hope you enjoy your travels to both (I live in England, myself) and your retirement in general.

Happy to take over if you'd like:)

mandolyte commented 1 year ago

@jessp01 I think I can just transfer the repo to you. But thought I'd make sure that was the best approach. What do you recommend?

jessp01 commented 1 year ago

Hi @mandolyte ,

Yes, I think that'd be fine:)

mandolyte commented 1 year ago

I got an error. Looks like you need to (re)move your repo with same name... image

jessp01 commented 1 year ago

Ah, I thought you'd just grant my user write privileges on the existing repo, or in other words, set me up as a "collaborator":) https://github.com/mandolyte/mdtopdf/settings/access

That way, you could still co-maintain it with me whenever you're so inclined and we needn't redirect from https://github.com/mandolyte/mdtopdf.

mandolyte commented 1 year ago

I see. That makes sense. I have added you. You should have an invite.

jessp01 commented 1 year ago

Happily accepted and just merged my own pull :) Thanks, @mandolyte. Enjoy your retirement!

mandolyte commented 9 months ago

@jessp01 I noticed some new issues. Will you be able to take a look? BTW, I am in England also until April (near London). Warmer, but wetter than Cincinnati :-)

jessp01 commented 9 months ago

Hi @mandolyte ,

Hope you're well. I can only see two issues from the same user pertaining to the use of the Noto Sans font. I've posted a comment on these. Were you referring to those or something else?

PS Enjoy your time in England:)

mandolyte commented 9 months ago

Yes, those were the ones. Looks like he isn't interested now. Consider closing unless you can replicate (or if you can't replicate, demonstrate what should have worked).

Thanks

On Thu, Feb 15, 2024, 4:38 PM Jesse Portnoy @.***> wrote:

Hi @mandolyte https://github.com/mandolyte ,

Hope you're well. I can only see two issues from the same user pertaining to the use of the Noto Sans font. I've posted a comment on these. Were you referring to those or something else?

PS Enjoy your time in England:)

— Reply to this email directly, view it on GitHub https://github.com/mandolyte/mdtopdf/issues/45#issuecomment-1946532051, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ2ZXL7LNG26ZBCQA3E3R3YTY2Z3AVCNFSM6AAAAAA5EQLVOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBWGUZTEMBVGE . You are receiving this because you were mentioned.Message ID: @.***>