search

mandrewcito / signalrcore

SignalR Core python client
https://mandrewcito.github.io/signalrcore/
MIT License
115 stars 53 forks source link

Added callback option for invocations #26

Closed lhotamir closed 4 years ago

lhotamir commented 4 years ago

I have added option for a callback when sending an invocation to the hub. I believe it is the feature requested in #23

mandrewcito commented 4 years ago

Thank you, i will accept your PR but first i will make some tests for the new feature!

lhotamir commented 4 years ago

I can try to add some tests myself tomorrow, I need to resolve the conflicts anyway

codecov-commenter commented 4 years ago

Codecov Report

Merging #26 into master will increase coverage by 0.13%. The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   86.84%   86.97%   +0.13%     
==========================================
  Files          26       26              
  Lines         821      837      +16     
==========================================
+ Hits          713      728      +15     
- Misses        108      109       +1
Impacted Files Coverage Δ
test/send_test.py 95.52% <90.00%> (-0.97%) :arrow_down:
signalrcore/hub/base_hub_connection.py 73.76% <100.00%> (+0.80%) :arrow_up:
signalrcore/hub_connection_builder.py 92.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5184bfe...d9ed13a. Read the comment docs.

lhotamir commented 4 years ago

I have resolved the conflict and added a new test, feel free to add more if you have some in mind

mandrewcito commented 4 years ago

Wow, so cool, thank you! I will publish a release on pypi :D