search

mandrewcito / signalrcore

SignalR Core python client
https://mandrewcito.github.io/signalrcore/
MIT License
116 stars 55 forks source link

Cleanup option setting in reconnect builder #40

Closed synapticarbors closed 3 years ago

synapticarbors commented 4 years ago

This PR cleans up the verbose setting of parameters when configuring automatic re-connects, opting for using the .get() method of the dict with a default value rather than testing key existence.

codecov[bot] commented 4 years ago

Codecov Report

Merging #40 into master will increase coverage by 0.68%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   92.74%   93.42%   +0.68%     
==========================================
  Files          30       30              
  Lines        1020     1065      +45     
==========================================
+ Hits          946      995      +49     
+ Misses         74       70       -4
Impacted Files Coverage Δ
signalrcore/hub_connection_builder.py 100.00% <100.00%> (ø)
test/send_test.py 98.94% <0.00%> (-1.06%) :arrow_down:
signalrcore/helpers.py 96.07% <0.00%> (-0.54%) :arrow_down:
signalrcore/protocol/base_hub_protocol.py 86.04% <0.00%> (-0.32%) :arrow_down:
test/open_close_test.py 100.00% <0.00%> (ø)
test/reconnection_test.py 97.43% <0.00%> (+0.51%) :arrow_up:
signalrcore/hub/base_hub_connection.py 82.48% <0.00%> (+2.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90540f3...338d81c. Read the comment docs.