mandrewcito / signalrcore

SignalR Core python client
https://mandrewcito.github.io/signalrcore/
MIT License
119 stars 57 forks source link

Patched websocket transport to support websocket-client 1.0.0 #61

Closed morpheus65535 closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #61 (03ba115) into main (13aaa64) will decrease coverage by 0.47%. The diff coverage is 72.22%.

:exclamation: Current head 03ba115 differs from pull request most recent head 6135eab. Consider uploading reports for the commit 6135eab to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   94.11%   93.63%   -0.48%     
==========================================
  Files          34       34              
  Lines        1274     1273       -1     
==========================================
- Hits         1199     1192       -7     
- Misses         75       81       +6     
Impacted Files Coverage Δ
signalrcore/protocol/messagepack_protocol.py 75.00% <0.00%> (-2.32%) :arrow_down:
...lrcore/transport/websockets/websocket_transport.py 81.69% <85.71%> (-2.07%) :arrow_down:
test/reconnection_test.py 97.18% <100.00%> (-0.12%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13aaa64...6135eab. Read the comment docs.

morpheus65535 commented 3 years ago

@mandrewcito appreciate the help, thanks!

mandrewcito commented 3 years ago

@morpheus65535 Thanks for your code !! today i had time to work on the project. Current year I´m working and cursing a data science master degree. I have not much time: S.

I would like to review and merge all PR this week

morpheus65535 commented 3 years ago

@morpheus65535 Thanks for your code !! today i had time to work on the project. Current year I´m working and cursing a data science master degree. I have not much time: S.

I would like to review and merge all PR this week

That's a pleasure mate. I totally get what you're in and appreciate the time you put in this project!