manekinekko / angular-search-experience

Algolia + Angular = 🔥🔥🔥
MIT License
166 stars 28 forks source link

refactor: update angular versions to master builds #11

Closed manekinekko closed 5 years ago

manekinekko commented 6 years ago

We should use angular#master^HEAD See this PR as a reference: https://github.com/xlayers/xlayers/pull/50

tinesoft commented 6 years ago

Ok, i'm on it!

tinesoft commented 6 years ago

Ok, quick update on this issue: Versions have been updated(see https://github.com/tinesoft/angular-search-experience/commit/8e86d102246d0a44de6274fff7bc02053181309f), but there are currently 2 issues when ng building or ng serving the app: image

manekinekko commented 6 years ago

thanks for the updates.

thanhpd commented 6 years ago

May I ask why should we switch to master builds? There's no guarantee that the latest version will work without error, which is the reason official stable releases exist.

manekinekko commented 5 years ago

Closing this feature request. Reason: Angular master builds may introduce some incompatibilities with 3rd party libs.