search

manekinekko / angular-web-bluetooth

The missing Web Bluetooth module for Angular
https://manekinekko.github.io/angular-web-bluetooth/
MIT License
196 stars 59 forks source link

upgrade to angular 7 and fixed observeValuse$ after upgrade to rxjs 6+ #52

Closed ChewieWookie closed 6 years ago

ChewieWookie commented 6 years ago

Hi,

I took liberty of upgrading your module to angular 7 and also newer versions of other dependencies as I was also upgrading my project.

It works, maybe it is not done in the most professional way but it works for me just fine.

I also found bug in observeValues$ method. I added pipe, moved takeUntil at the end of pipe to prevent leaks and also changed the way you create observables from events of objects ( Observable.create was not working as before in rxjs 6.3, I changed it to fromEvent function and now it works fine )

Feel free to merge it if you want and think that it will help.

Regards.

ChewieWookie commented 6 years ago

Great :) I cannot merge these changes as I do not have write access.

Could you do it?

manekinekko commented 6 years ago

Sure. I've scheduled this PR to be merged (on my todolist) :)

ChewieWookie commented 6 years ago

Great :) Thanks!

manekinekko commented 6 years ago

Released: @manekinekko/angular-web-bluetooth@4.0.0.