search

manekinekko / angular-web-bluetooth

The missing Web Bluetooth module for Angular
https://manekinekko.github.io/angular-web-bluetooth/
MIT License
196 stars 59 forks source link

Add disconnect method #53

Closed sajeetharan closed 5 years ago

manekinekko commented 6 years ago

Hi @sajeetharan Thank you for taking the time and sending this PR.

However, this is not what's expected by issue #50. What we would like is to add a disconnect method on the core service, not the file you've changed.

The code you've send doesn't contain a method body, maybe this wasn't intended! Anyways, the disconnect method should send a disconnect command to the GATT server and ends the connection.

Would you like to update this PR accordingly? lmk if you need some help.

Cheers.

sajeetharan commented 6 years ago

Hi @manekinekko Sorry for the wrong PR, i just read the title and the keyword in the description and created it on the client. I will create a new one

manekinekko commented 6 years ago

Hi @sajeetharan No worries. No big deal. However, there is already an open PR which fixes issue #50 --> PR https://github.com/manekinekko/angular-web-bluetooth/pull/55

You can still check the PR out and give us your feedback. I havent had time to review it yet ^^

manekinekko commented 5 years ago

fixed in #55