Reconnection failed but success callback was executed

Hi :)

Describe the bug When I try to reconnect to previously connected device and this reconnection failed because the device is no longer available ( turned off bluetooth ), success callback is called instead of error.

To Reproduce Steps to reproduce the behavior:

Connect to device
Turn off the device's bluetooth
Wait for a reconnection try
See that the success callback is executed

Expected behavior Method connectDevice$() should give an observable that in case of every failure in connecting a device will execute error callback

Code Invoking Reconnection

private reconnect() {
        console.info('Reconnecting');
        this.tryReconnect(3, 2,
            () => {
                return this.ble.connectDevice$(this.bluetoothDevice);
            },
            (server: BluetoothRemoteGATTServer) => {
                console.info('Reconnection success');
            },
            (error) => {
                console.error(error);
                throw error;
            }
        );
    }

Subscribing to Observable

tryReconnect(retries: number, delay: number, toTry:() => Observable<any>, success: (obj:any) => void, fail: (text: any) => void){
        console.info('Try count: ' + retries);
        toTry().subscribe(
                result => success(result),
                error => {
                    if(retries == 0){
                        return fail(error);
                    }
                    console.info('Retry: ' + retries);
                    setTimeout(() => {
                        this.tryReconnect(--retries, delay,toTry,success,fail);
                    }, delay * 1000);
                }
            )
    }

Here the error callback with console.info('Retry'.... ) newer actually logs that message. Instead console.info('Reconnection success') is logged.

manekinekko / angular-web-bluetooth

Reconnection failed but success callback was executed #56