manet-marketing / gelf_redux

MIT License
5 stars 0 forks source link

Support for ActiveSupport 7 #8

Open christianrolle opened 2 weeks ago

christianrolle commented 2 weeks ago

Is it planned to bump the dependency to ActiveSupport from v6.1.7.6 to 7.x?

ronald commented 2 weeks ago

AFAIK There's no runtime dependency on ActiveSupport.

But we should set up automatic testing and use different and current versions of Ruby (main is using EOLed Ruby 2.6).

Quick test with Ruby 3.1 and activesupport-7.0.8.4 gelf_redux-app-1 | Loaded suite /bundle/ruby/3.1.0/gems/rake-13.2.1/lib/rake/rake_test_loader gelf_redux-app-1 | Started gelf_redux-app-1 | I'm a Ruby > 2.0.0. Enforcing ASCII-8BIT. (3.1.1/3) gelf_redux-app-1 | Finished in 0.000452229 seconds. gelf_redux-app-1 | ------------------------------------------------------------------------------- gelf_redux-app-1 | 122 tests, 194 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications gelf_redux-app-1 | 100% passed gelf_redux-app-1 | ------------------------------------------------------------------------------- gelf_redux-app-1 | 269774.83 tests/s, 428986.20 assertions/s gelf_redux-app-1 | Coverage report generated for Unit Tests to /usr/src/app/coverage. 646 / 732 LOC (88.25%) covered. gelf_redux-app-1 exited with code 0